Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 5, 2007, 19:38 UTC
- Message-ID
- <7vtzmxortn.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1196869526-2197-1-git-send-email-jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 30 quoted lines
> diff --git a/configure.ac b/configure.ac
> index 5f8a15b..5d2936e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -212,6 +212,27 @@ test -n "$NEEDS_SOCKET" && LIBS="$LIBS -lsocket"
>
>
> ## Checks for header files.
> +AC_MSG_NOTICE([CHECKS for header files])
> +#
> +# Define OLD_ICONV if your library has an old iconv(), where the second
> +# (input buffer pointer) parameter is declared with type (const char **).
> +AC_DEFUN([OLDICONVTEST_SRC], [[
> +#include <iconv.h>
> +
> +int main(void)
> +{
> + iconv_t cd;
> + char *ibp, *obp;
> + size_t insz, outsz;
> + iconv(cd, &ibp, &insz, &obp, &outsz);
> +}
> +]])
> +AC_MSG_CHECKING([for old iconv()])
> +AC_COMPILE_IFELSE(OLDICONVTEST_SRC,
> + [AC_MSG_RESULT([no])],
> + [AC_MSG_RESULT([yes])
> + OLD_ICONV=YesPlease])
> +AC_SUBST(OLD_ICONV)
> Which result does COMPILE_IFELSE give for non error warnings? Ok, or Bad?