Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Dec 5, 2007, 16:11 UTC
Message-ID: <82D48BF0-E01D-4CE4-92F3-44B555531624@silverinsanity.com>
In-Reply-To: <1196869526-2197-1-git-send-email-jnareb@gmail.com>

On Dec 5, 2007, at 10:45 AM, Jakub Narebski wrote:

Show 11 quoted lines

> Update configure.ac (and config.mak.in) to keep up with git
> development by adding [compile] test whether your library has
> an old iconv(), where the second (input buffer pointer) parameter
> is declared with type (const char **) (OLD_ICONV).
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This patch needs checking if it correctly sets OLD_ICONV
> when needed.  I have checked only that it is not set when
> with new iconv() declaration.  Could people using Cygwin
> (and other with OLD_ICONV: Darwin) test it?

I could not get git am to apply the patch cleanly, but will try again later when I have more time. That said, 10.5's default /usr/include/ iconv.h uses the newer non-const definition of iconv_open. I've had to add a "OLD_ICONV=" line to my config.mak to avoid the warning. I'll still test to look for a false positive.

> P.S. Is there any convention on where to use YesPlease, and where
> UnfortunatelyYes when setting Makefile build configuration variables?

AFAICT, YesPlease is the "normal" choice and UnfortunatelyYes is used when the person who added it considered it an obnoxious hack or a stupid failing in a system. The test in the Makefile is just if the variable is defined, so you technically could use "IDontLikeSillyVariableValuesInMyMakefiles", and it would work just fine. ;-)

~~ Brian