Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV

From: Wincent Colaiuta <win@wincent.com>
Date: Dec 5, 2007, 20:49 UTC
Message-ID: <52A4CC8B-EB11-4E3F-A3B6-06826F860E5D@wincent.com>
In-Reply-To: <200712051752.28667.jnareb@gmail.com>

El 5/12/2007, a las 17:52, Jakub Narebski escribió:

Show 21 quoted lines

> On Wed, 5 December 2007, Wincent Colaiuta wrote:
>>
>> Before applying your patch:
>>
>>     CC utf8.o
>> utf8.c: In function ‘reencode_string’:
>> utf8.c:328: warning: passing argument 2 of ‘iconv’ from incompatible
>> pointer type
>>     CC convert.o
>>
>> After applying your patch:
>>
>>     CC utf8.o
>>     CC convert.o
>
> Do I understand correctly that above is excerpt from the output of the
> following sequence of commands before and after this patch applied?
>
>  $ make configure
>  $ ./configure [options]
>  $ make

Yes, that's right, but with a "make clean" before anything else.

> Do you have something like below in ./configure output?
>
>  configure: CHECKS for header files
>  checking for old iconv()... yes

This:

configure: CHECKS for header files checking for old iconv()... no

Show 13 quoted lines

>> This on Darwin Kernel Version 9.1.0 (Mac OS X 10.5.1).
>
> Strange... in Makefile there is
>
>  ifeq ($(uname_S),Darwin)
> 	NEEDS_SSL_WITH_CRYPTO = YesPlease
> 	NEEDS_LIBICONV = YesPlease
> 	OLD_ICONV = UnfortunatelyYes
> 	NO_STRLCPY = YesPlease
> 	NO_MEMMEM = YesPlease
>  endif
>
> so the uname based guessing should set OLD_ICONV on Darwin...

That happens *before* config.mak.autogen is included in the Makefile, so it gets overridden.

Cheers, Wincent