Re: [PATCH/RFC] autoconf: Add test for OLD_ICONV

From: Pascal Obry <pascal@obry.net>
Date: Dec 5, 2007, 21:46 UTC
Message-ID: <47571C4B.5060907@obry.net>
In-Reply-To: <1196869526-2197-1-git-send-email-jnareb@gmail.com>

Jakub Narebski a écrit :

Show 6 quoted lines

> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This patch needs checking if it correctly sets OLD_ICONV
> when needed.  I have checked only that it is not set when
> with new iconv() declaration.  Could people using Cygwin
> (and other with OLD_ICONV: Darwin) test it?

Not working on Cygwin:

   $ autoconf
   $ ./configure --prefix=/usr/local --build=i686-pc-cygwin
   ...
   configure: CHECKS for header files
   checking for old iconv()... no

It should be yes above. And in config.mak.autogen we have:

   OLD_ICONV=

Note also that you should remove all the hard-coded settings in Makefile anyway.

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595