git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] autoconf: Add tests for memmem, strtoumax and mkdtemp functions

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 21, 2007, 18:47 UTC
Message-ID
<200711211947.50661.jnareb@gmail.com>
In-Reply-To
<20071121065858.GU14735@spearce.org>
Shawn O. Pearce wrote:
Show 19 quoted lines
> Jakub Narebski <jnareb@gmail.com> wrote:
>> By the way, do you have idea how to test for the following
>> in configure.ac:
>> 
>> * Define NO_PREAD if you have a problem with pread() system call (e.g.
>>   cygwin.dll before v1.5.22).
>> 
>>   - what is the problem? how to detect it?
> 
> This also appears to be broken on HP-UX (e.g. we need to set
> NO_PREAD there).  Thiago on IRC talked about this the other day
> when he was trying to build git on a bunch of different systems.
> 
> Unfortunately this may just need to be an OS based test.  The code
> compiles just fine but when index-pack tries to use pread to walk
> back through the deltas and generate their SHA-1s it barfs without
> an error code.  I suspect the failure is pread claiming it put the
> data into the user buffer but not actually doing so, which causes
> zlib's inflate() to then see data corruption.

Can you write a short program which demonstrates this error (either fails with some error code, or produces wrong output)? That would be enough for configure.ac (see for example NO_C99_FORMAT in configure.ac)

Unless this is Schroedinger bug...
-- 
Jakub Narebski
Poland
Previous: Shawn O. PearceNext: Stefan-W. Hahn
Message 3 of 20 in “autoconf: Add tests for memmem, strtoumax and mkdtemp functions”
  1. autoconf: Add tests for memmem, strtoumax and mkdtemp functionsJakub Narebski, Nov 19, 2007
  2. Shawn O. PearceNov 21, 2007
  3. Jakub NarebskiNov 21, 2007
  4. Stefan-W. HahnNov 20, 2007
  5. Matt KraaiNov 21, 2007
  6. autoconf: Add test for OLD_ICONVJakub Narebski, Dec 5, 2007
  7. Brian GernhardtDec 5, 2007
  8. Jakub NarebskiDec 5, 2007
  9. Wincent ColaiutaDec 5, 2007
  10. Jakub NarebskiDec 5, 2007
  11. Wincent ColaiutaDec 5, 2007
  12. Jakub NarebskiDec 5, 2007
  13. Brian GernhardtDec 5, 2007
  14. Wincent ColaiutaDec 6, 2007
  15. Junio C HamanoDec 5, 2007
  16. Jakub NarebskiDec 5, 2007
  17. Junio C HamanoDec 5, 2007
  18. autoconf: Add test for OLD_ICONV (squelching compiler warning)Jakub Narebski, Dec 5, 2007
  19. Junio C HamanoDec 5, 2007
  20. Pascal ObryDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.