Re: What's cooking in git.git (Feb 2011, #05; Wed, 23)
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 24, 2011, 02:07 UTC
- Message-ID
- <AANLkTinfAESXU6OaDEqgcU7tppE2PUR=mxYpT94tOJ8j@mail.gmail.com>
- In-Reply-To
- <7v4o7u42g9.fsf@alter.siamese.dyndns.org>
On Thu, Feb 24, 2011 at 02:59, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> Right, once we're confident (which at least I am) that the first few >> patches really are no-op's I think it would be easier for everyone to >> merge them down sooner than later. > > We three are pretty much on the same page, then. > > Two minor points are what to do with the "#" prefix in "# POISON #"
The root cause of this is solved in a patch by Jonathan:
https://github.com/avar/git/commit/da15d84430e5f9b68125f6ddad61f66251c991ac
I thought it was better to submit it later once this was in. The current behavior is harmless hack that we're aware of.
> namespace contamination,
You mean just _ being propagated everywhere? That seems harmless.
> but other than these I don't think there is anything controversial.
Great.
>> s/corrected/connected/ also :) > > That typo appears only in _your_ version, not mine ;-).
Indeed. I was amending my suggestion, not your original :)