ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23))

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 23, 2011, 23:48 UTC
Message-ID: <20110223234828.GA7286@elie>
In-Reply-To: <7v1v2y5o3p.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> * ab/i18n (2011-02-22) 73 commits

[...]

Show 11 quoted lines

>  - i18n: do not poison translations unless GIT_GETTEXT_POISON envvar is set
>  - i18n: add GETTEXT_POISON to simulate translated messages unfriendly translator
>  - i18n: add no-op _() and N_() wrappers
>
> Re^4-roll, coordinated between Ævar and Jonathan.
>
> I'd like to fast-track the basics (especially the bottom 3 patches), and
> am even tempted to rebase other patches on 'pu' that are not yet in 'next'
> on top of them, to make the transition easier, so please lend extra sets
> of eyeballs on an earlier ones to make sure they are sane (I thought they
> were, but I am far from perfect).

The commit message for the second one seems to have been mangled:

	i18n: add GETTEXT_POISON to simulate translated messages unfriendly translator

Before, it said "simulate unfriendly translator", as in "turn on this option to see what the translator from hell could do to your program". (Well, it's not _that_ bad because it takes out format strings.)

I still don't like the #-sign business in this commit. Couldn't it be split into a separate patch, not to be applied until just before the strings in commit/tag/wt-status are marked for translation?

There is also a patch out there to make this use rot13, which I am somewhat fond of. Unfortunately, it leaks (because it is not clear how long translated strings are supposed to last).

I'd be happy with renaming use_poison() to gettext_poison() or similar. I suppose that is not urgent.

Regards, Jonathan