git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23))

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 24, 2011, 10:38 UTC
Message-ID
<AANLkTikfqmPKA0T4Q-ac0CXzqmCEp0cWNskODEjmACW_@mail.gmail.com>
In-Reply-To
<20110224031414.GC7970@elie>
On Thu, Feb 24, 2011 at 04:14, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 15 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>
>> Anyway, to be blunt I really don't see the point of fiddling around
>> with this bit so much. Whether it's a `"GETTEXT POISON"` constant or
>> `rot13(msgid)` the same tests will fail.
>
> Because with rot13 you can decode the message and find the problematic
> code?
>
>> If someone else wants to do the work I don't care. I just think
>> there's more important things to worry about.
>
> I already wrote a patch.  I imagine you don't intend it this way, but
> I keep on hearing "we shouldn't do what you've already done.  It's too
> much trouble.  You wasted your time."

I don't mean it that way at all, I just mean that as a comment to *this* particular patch series I don't think it's something we have to worry about.

I.e. if you look at this in context we have a 170 gettext patch series to trickle in gradually. Right now we have 70 pending with only the C translations. Hopefully we can fast-track this to have around 150 of those in in the next month or so.

What I want to focus on is getting this right for users of Git, and I think it's already good enough for that purpose. I'm not worried about an embedded debug testing mode that to my knowledge only you and I have used so far.

If it has some changes for improvement I think they can be dealt with later, doing it at this point means more code to review. Right now the C code in the series is around 10 lines, doing something like the rot13 implementation would at least triple that, making in not leak memory (and hence have automated tools complain) would be even more code.

Again, don't get me wrong. I really appreciate your work. I just don't think this is something we need to worry about now.

Previous: Jonathan NiederNext: Jonathan Nieder
Message 6 of 46 in “What's cooking in git.git (Feb 2011, #05; Wed, 23)”
  1. Junio C HamanoFeb 23, 2011
  2. ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23))Jonathan Nieder, Feb 23, 2011
  3. Junio C HamanoFeb 24, 2011
  4. Ævar Arnfjörð BjarmasonFeb 24, 2011
  5. Jonathan NiederFeb 24, 2011
  6. Ævar Arnfjörð BjarmasonFeb 24, 2011
  7. Jonathan NiederFeb 24, 2011
  8. Jonathan NiederFeb 24, 2011
  9. Ævar Arnfjörð BjarmasonFeb 25, 2011
  10. Jonathan NiederFeb 26, 2011
  11. Jonathan NiederFeb 24, 2011
  12. Erik Faye-LundFeb 24, 2011
  13. Jonathan NiederFeb 24, 2011
  14. Junio C HamanoFeb 24, 2011
  15. Ævar Arnfjörð BjarmasonFeb 24, 2011
  16. Johan HerlandFeb 23, 2011
  17. Junio C HamanoFeb 24, 2011
  18. Johan HerlandFeb 24, 2011
  19. Ævar Arnfjörð BjarmasonFeb 24, 2011
  20. Junio C HamanoFeb 24, 2011
  21. Ævar Arnfjörð BjarmasonFeb 24, 2011
  22. Junio C HamanoFeb 24, 2011
  23. Ævar Arnfjörð BjarmasonFeb 24, 2011
  24. Erik Faye-LundFeb 24, 2011
  25. Ævar Arnfjörð BjarmasonFeb 24, 2011
  26. Jonathan NiederFeb 24, 2011
  27. Johannes SchindelinFeb 25, 2011
  28. Kirill SmelkovFeb 25, 2011
  29. Johannes SchindelinFeb 25, 2011
  30. Kirill SmelkovFeb 25, 2011
  31. Johannes SchindelinFeb 25, 2011
  32. Kirill SmelkovFeb 26, 2011
  33. Kirill SmelkovFeb 26, 2011
  34. cross-compiling msys-1.0.dll, was Re: What's cooking in git.git (Feb 2011, #05; Wed, 23)Johannes Schindelin, Feb 26, 2011
  35. Kirill SmelkovMar 12, 2011
  36. Johannes SchindelinMar 12, 2011
  37. Johannes SchindelinFeb 27, 2011
  38. Kirill SmelkovMar 12, 2011
  39. Adding Beyond Compare as a merge tool, was: Re: What's cooking in git.git (Feb 2011, #05; Wed, 23)Sebastian Schuberth, Feb 26, 2011
  40. Junio C HamanoFeb 26, 2011
  41. Sebastian SchuberthFeb 26, 2011
  42. Chris PackhamFeb 27, 2011
  43. Junio C HamanoFeb 27, 2011
  44. Sebastian SchuberthFeb 27, 2011
  45. Sebastian SchuberthFeb 27, 2011
  46. Sebastian SchuberthFeb 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.