Re: ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23))
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 24, 2011, 01:16 UTC
- Message-ID
- <7vd3mi44gx.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20110223234828.GA7286@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
> The commit message for the second one seems to have been mangled: > > i18n: add GETTEXT_POISON to simulate translated messages unfriendly translator
Yeah, I think I was fooled by the header folding while fixing things up inside the mailbox.
> I still don't like the #-sign business in this commit. Couldn't it > be split into a separate patch, not to be applied until just before > the strings in commit/tag/wt-status are marked for translation?
That might be a sensible thing to do. Ævar what do you think?
> There is also a patch out there to make this use rot13, which I am > somewhat fond of. Unfortunately, it leaks (because it is not clear > how long translated strings are supposed to last).
Yeah I would imagine it would leak. Also blindly running rot13 to turn %d into %q is probably not what you want.
> I'd be happy with renaming use_poison() to gettext_poison() or > similar. I suppose that is not urgent.
I would prefer to be able to merge the first handful to 'master' sooner rather than later to minimize the damage to in-flight topics, though.
Thanks.