git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] trace.c: mark file-local function static

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Dec 21, 2010, 14:52 UTC
Message-ID
<AANLkTinL6RytF=x7a8URoxGQoLHhx0ip7gRNMp+nRaNB@mail.gmail.com>
In-Reply-To
<1292863989.19322.27.camel@drew-northup.unet.maine.edu>
On Mon, Dec 20, 2010 at 11:53 PM, Drew Northup <drew.northup@maine.edu> wrote:
>> Why such trivial thing needs further explanation?
>
> Because even trivial fixes may break non-trivial things.
The only thing it could break is compilation.
> In addition, without justification we'd just as soon have somebody come
> back with another patch six months down the road that changes it back to
> the original code. Now that wouldn't make a whole lot of sense, now
> would it?

Yeah I would expect somebody reverting this patch _if_ this function is useful outside trace.c again. On the other hand, this patch saves do_nothing from global namespace so somewhere, some time, somebody can use it.

This is pretty much a clean-up patch from my perspective. Do we really need two paragraph explanation for marking a function static?

-- 
Duy
Previous: Thiago FarinaNext: Drew Northup
Message 9 of 14 in “trace.c: mark file-local function static”
  1. trace.c: mark file-local function staticVasyl', Dec 16, 2010
  2. Thiago FarinaDec 16, 2010
  3. Drew NorthupDec 20, 2010
  4. Thiago FarinaDec 20, 2010
  5. Drew NorthupDec 20, 2010
  6. Thiago FarinaDec 21, 2010
  7. Drew NorthupDec 21, 2010
  8. Thiago FarinaDec 21, 2010
  9. Nguyen Thai Ngoc DuyDec 21, 2010
  10. Drew NorthupDec 21, 2010
  11. Junio C HamanoDec 21, 2010
  12. Thiago FarinaDec 21, 2010
  13. Junio C HamanoDec 21, 2010
  14. Johannes SixtDec 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.