Re: [PATCH] trace.c: mark file-local function static

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 21, 2010, 19:54 UTC
Message-ID: <201012212054.27054.j6t@kdbg.org>
In-Reply-To: <7vbp4f9gzh.fsf@alter.siamese.dyndns.org>

On Dienstag, 21. Dezember 2010, Junio C Hamano wrote:

Show 8 quoted lines

> A more interesting topic is why the try-to-free-pack-memory logic needs to
> be disabled in the first place.  3a09425 (Do not call release_pack_memory
> in malloc wrappers when GIT_TRACE is used, 2010-05-08) explains that it is
> to avoid a race on Windows, and it looks like a workaround not a solution
> ("can be called without locking"---"why aren't we locking then?").
>
> Not that it matters in the context of "trace", which is a debugging
> facility, that this is a workaround.

Exactly. A clean implementation is not worth the effort for this debugging facility.

BTW, these days it is not just Windows that is affected because we use threads in start_async everywhere if possible.

-- Hannes