From: Nguyen Thai Ngoc Duy Date: Tue, 21 Dec 2010 14:52:59 GMT Subject: Re: [PATCH] trace.c: mark file-local function static Message-ID: In-Reply-To: <1292863989.19322.27.camel@drew-northup.unet.maine.edu> On Mon, Dec 20, 2010 at 11:53 PM, Drew Northup wrote: >> Why such trivial thing needs further explanation? > > Because even trivial fixes may break non-trivial things. The only thing it could break is compilation. > In addition, without justification we'd just as soon have somebody come > back with another patch six months down the road that changes it back to > the original code. Now that wouldn't make a whole lot of sense, now > would it? Yeah I would expect somebody reverting this patch _if_ this function is useful outside trace.c again. On the other hand, this patch saves do_nothing from global namespace so somewhere, some time, somebody can use it. This is pretty much a clean-up patch from my perspective. Do we really need two paragraph explanation for marking a function static? -- Duy