Re: [PATCH] trace.c: mark file-local function static

From: Thiago Farina <tfransosi@gmail.com>
Date: Dec 21, 2010, 15:59 UTC
Message-ID: <AANLkTimZ=xBCewESqQmOfOggkAOvqnZfavU2suLT6ATJ@mail.gmail.com>
In-Reply-To: <1292934581.26698.14.camel@drew-northup.unet.maine.edu>

On Tue, Dec 21, 2010 at 10:29 AM, Drew Northup <drew.northup@maine.edu> wrote:

> While I think the code change is fairly clear, as I said earlier: without a commit message we don't have
> a good reason for not making it non-static again later on, flip-flopping
> ad-infinitum.
>

Why you are complain about a one word change at all? Are you the maintainer? Are you going to make a change that uses do_nothing in future? If for some reason someone needs to use this function in other place, the problem is of this person not you, he you will have to argue and defend his change for whatever reasons he has, and will be a problem for the maintainer not for you.

Show 5 quoted lines

> Commit messages for isolated changes such as this build up a story, if
> you will, providing future contributors with insight as to why the group
> made a change when it did--even when the change is minor (in fact often
> most importantly when the change is minor)--by putting it in context.
>

We all know that, and Junio is doing a good job enforcing GOOD commit messages. But in this case this is STUPID in my pov (others can and probably will disagree with me, but I don't care).

Show 13 quoted lines

>> > Alas the best way to avoid such a situation is to explain why a change
>> > was made to begin with.
>> >
>>
>> So, you are welcome to contribute and suggest such description for
>> this trivial (that may break non-trivial things) patch. So we can
>> please you and others in the future.
>
> As I am complaining that I don't know what the submitter was thinking
> that sounds particularly odd to me. How I am supposed to describe for
> the group what the commit's author was thinking in a commit message that
> I would like to see added to a patch when in fact the whole problem is
> that I don't know specifically what he was thinking?

Well, what the hell we are talking about so? If you are arguing for a commit message, I would expect that you would have a suggestion, at least to show why you are so interested in this particular patch.

And many contributors here, besides suggesting BETTER commit messages, they help others with how the patch could be written, and you are not helping in either way.