Re: [PATCH] trace.c: mark file-local function static

From: Drew Northup <drew.northup@maine.edu>
Date: Dec 21, 2010, 15:19 UTC
Message-ID: <1292944750.26698.16.camel@drew-northup.unet.maine.edu>
In-Reply-To: <AANLkTinL6RytF=x7a8URoxGQoLHhx0ip7gRNMp+nRaNB@mail.gmail.com>

On Tue, 2010-12-21 at 21:52 +0700, Nguyen Thai Ngoc Duy wrote:

> On Mon, Dec 20, 2010 at 11:53 PM, Drew Northup <drew.northup@maine.edu> wrote:

Show 7 quoted lines

> Yeah I would expect somebody reverting this patch _if_ this function
> is useful outside trace.c again. On the other hand, this patch saves
> do_nothing from global namespace so somewhere, some time, somebody can
> use it.
> 
> This is pretty much a clean-up patch from my perspective. Do we really
> need two paragraph explanation for marking a function static?

No, but 1 sentence would be dandy.

-- 
-Drew Northup N1XIM
   AKA RvnPhnx on OPN
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59