Re: [PATCH] trace.c: mark file-local function static
- From
Drew Northup <drew.northup@maine.edu>
- Date
- Dec 20, 2010, 12:00 UTC
- Message-ID
- <1292846433.19322.1.camel@drew-northup.unet.maine.edu>
- In-Reply-To
- <AANLkTimBtpOx_GBzC=g4V6jW2aiF7Hg8uALWt2NQFFZG@mail.gmail.com>
On Thu, 2010-12-16 at 21:43 -0200, Thiago Farina wrote:
Show 22 quoted lines
> On Thu, Dec 16, 2010 at 8:38 PM, Vasyl' <vvavrychuk@gmail.com> wrote:
> > Signed-off-by: Vasyl' Vavrychuk <vvavrychuk@gmail.com>
> > ---
> > trace.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/trace.c b/trace.c
> > index 1e560cb..62586fa 100644
> > --- a/trace.c
> > +++ b/trace.c
> > @@ -25,7 +25,7 @@
> > #include "cache.h"
> > #include "quote.h"
> >
> > -void do_nothing(size_t unused)
> > +static void do_nothing(size_t unused)
> > {
> > }
> >
> If it means something, this looks sane to me.
>
> Acked-by: Thiago Farina <tfransosi@gmail.com>It may be sane, but why should we trust that it is without a commit message?
-- -Drew Northup N1XIM AKA RvnPhnx on OPN ________________________________________________ "As opposed to vegetable or mineral error?" -John Pescatore, SANS NewsBites Vol. 12 Num. 59