RE: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()

From: Li Yang-r58472 <leoli@freescale.com>
Date: Mar 6, 2007, 11:07 UTC
Message-ID: <989B956029373F45A0B8AF02970818902DAA14@zch01exm26.fsl.freescale.net>
In-Reply-To: <20070306110156.GA13380@coredump.intra.peff.net>

Show 13 quoted lines

> -----Original Message-----
> From: Jeff King [mailto:peff@peff.net]
> Sent: Tuesday, March 06, 2007 7:02 PM
> To: Junio C Hamano
> Cc: Li Yang-r58472; Jakub Narebski; git@vger.kernel.org
> Subject: Re: [PATCH] gitweb: Change to use explicitly function call
> cgi->escapHTML()
> 
> On Tue, Mar 06, 2007 at 02:58:37AM -0800, Junio C Hamano wrote:
> 
> > Sorry, what I meant to say was on top of Li's patch.
> 
> Ah, I understand your point now. Yes, if other mod_perl CGIs can

impact

> the value, then we should definitely set it explicitly, as per your
> patch (and we should use Li's patch for safety, then, not mine).

I agree.

-Leo