git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()

From
LYLi Yang <leoli@freescale.com>
Date
Mar 6, 2007, 03:58 UTC
Message-ID
<45ECE700.8090205@freescale.com>

Change to use explicitly function call cgi->escapHTML(). This fix the problem on some systems that escapeHTML() is not functioning, as default CGI is not setting 'escape' parameter.

Signed-off-by: Li Yang <leoli@freescale.com>
---
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 653ca3c..3a564d1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -591,7 +591,7 @@ sub esc_html ($;%) {
 	my %opts = @_;
 
 	$str = to_utf8($str);
-	$str = escapeHTML($str);
+	$str = $cgi->escapeHTML($str);
 	if ($opts{'-nbsp'}) {
 		$str =~ s/ /&nbsp;/g;
 	}
@@ -605,7 +605,7 @@ sub esc_path {
 	my %opts = @_;
 
 	$str = to_utf8($str);
-	$str = escapeHTML($str);
+	$str = $cgi->escapeHTML($str);
 	if ($opts{'-nbsp'}) {
 		$str =~ s/ /&nbsp;/g;
 	}
Next: Junio C Hamano
Message 1 of 21 in “gitweb: Change to use explicitly function call cgi->escapHTML()”
  1. gitweb: Change to use explicitly function call cgi->escapHTML()Li Yang, Mar 6, 2007
  2. Junio C HamanoMar 6, 2007
  3. Jakub NarebskiMar 6, 2007
  4. Jeff KingMar 6, 2007
  5. Junio C HamanoMar 6, 2007
  6. Li Yang-r58472Mar 6, 2007
  7. Jeff KingMar 6, 2007
  8. Junio C HamanoMar 6, 2007
  9. Jeff KingMar 6, 2007
  10. Junio C HamanoMar 6, 2007
  11. Jeff KingMar 6, 2007
  12. Junio C HamanoMar 6, 2007
  13. Jeff KingMar 6, 2007
  14. Li Yang-r58472Mar 6, 2007
  15. Junio C HamanoMar 6, 2007
  16. Jakub NarebskiMar 6, 2007
  17. Junio C HamanoMar 6, 2007
  18. Jakub NarebskiMar 7, 2007
  19. Junio C HamanoMar 7, 2007
  20. gitweb: Don't escape attributes in CGI.pm HTML methodsJakub Narebski, Mar 7, 2007
  21. Junio C HamanoMar 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.