Re: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()

From: Jakub Narebski <jnareb@gmail.com>
Date: Mar 6, 2007, 09:34 UTC
Message-ID: <8fe92b430703060134l14fffcc4rbece3c2071c56422@mail.gmail.com>
In-Reply-To: <7v649euai8.fsf@assigned-by-dhcp.cox.net>

On 3/6/07, Junio C Hamano <junkio@cox.net> wrote:

Show 10 quoted lines

> Li Yang <leoli@freescale.com> writes:
>
> > Change to use explicitly function call cgi->escapHTML().
> > This fix the problem on some systems that escapeHTML() is not
> > functioning, as default CGI is not setting 'escape' parameter.
> >
> > Signed-off-by: Li Yang <leoli@freescale.com>
>
> Regardless of the recent xhtml+html vs html discussion, I think
> this is probably a sane change.  Comments?

Good (although a bit magic) solution. Ack, FWIW.

-- 
Jakub Narebski