RE: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()
- From
- Li Yang-r58472 <leoli@freescale.com>
- Date
- Mar 6, 2007, 10:31 UTC
- Message-ID
- <989B956029373F45A0B8AF02970818902DAA12@zch01exm26.fsl.freescale.net>
- In-Reply-To
- <20070306093917.GA1761@coredump.intra.peff.net>
Show 16 quoted lines
> -----Original Message----- > From: Jeff King [mailto:peff@peff.net] > Sent: Tuesday, March 06, 2007 5:39 PM > To: Jakub Narebski > Cc: Junio C Hamano; Li Yang-r58472; git@vger.kernel.org > Subject: Re: [PATCH] gitweb: Change to use explicitly function call > cgi->escapHTML() > > On Tue, Mar 06, 2007 at 10:34:32AM +0100, Jakub Narebski wrote: > > > >Regardless of the recent xhtml+html vs html discussion, I think > > >this is probably a sane change. Comments? > > Good (although a bit magic) solution. Ack, FWIW. > > I think this should do the same, and is perhaps less magic (or maybe > more, depending on your perspective).
Yes, it also fixed the problem. I'm not very familiar with perl. Will CGI::autoEscape(1) change CGI action for other users of CGI module on the system? If so, maybe it will break other CGIs.
- Leo