git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()

From
LYLi Yang-r58472 <leoli@freescale.com>
Date
Mar 6, 2007, 10:31 UTC
Message-ID
<989B956029373F45A0B8AF02970818902DAA12@zch01exm26.fsl.freescale.net>
In-Reply-To
<20070306093917.GA1761@coredump.intra.peff.net>
Show 16 quoted lines
> -----Original Message-----
> From: Jeff King [mailto:peff@peff.net]
> Sent: Tuesday, March 06, 2007 5:39 PM
> To: Jakub Narebski
> Cc: Junio C Hamano; Li Yang-r58472; git@vger.kernel.org
> Subject: Re: [PATCH] gitweb: Change to use explicitly function call
> cgi->escapHTML()
> 
> On Tue, Mar 06, 2007 at 10:34:32AM +0100, Jakub Narebski wrote:
> 
> > >Regardless of the recent xhtml+html vs html discussion, I think
> > >this is probably a sane change.  Comments?
> > Good (although a bit magic) solution. Ack, FWIW.
> 
> I think this should do the same, and is perhaps less magic (or maybe
> more, depending on your perspective).

Yes, it also fixed the problem. I'm not very familiar with perl. Will CGI::autoEscape(1) change CGI action for other users of CGI module on the system? If so, maybe it will break other CGIs.

- Leo
Previous: Junio C HamanoNext: Jeff King
Message 6 of 21 in “gitweb: Change to use explicitly function call cgi->escapHTML()”
  1. gitweb: Change to use explicitly function call cgi->escapHTML()Li Yang, Mar 6, 2007
  2. Junio C HamanoMar 6, 2007
  3. Jakub NarebskiMar 6, 2007
  4. Jeff KingMar 6, 2007
  5. Junio C HamanoMar 6, 2007
  6. Li Yang-r58472Mar 6, 2007
  7. Jeff KingMar 6, 2007
  8. Junio C HamanoMar 6, 2007
  9. Jeff KingMar 6, 2007
  10. Junio C HamanoMar 6, 2007
  11. Jeff KingMar 6, 2007
  12. Junio C HamanoMar 6, 2007
  13. Jeff KingMar 6, 2007
  14. Li Yang-r58472Mar 6, 2007
  15. Junio C HamanoMar 6, 2007
  16. Jakub NarebskiMar 6, 2007
  17. Junio C HamanoMar 6, 2007
  18. Jakub NarebskiMar 7, 2007
  19. Junio C HamanoMar 7, 2007
  20. gitweb: Don't escape attributes in CGI.pm HTML methodsJakub Narebski, Mar 7, 2007
  21. Junio C HamanoMar 7, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.