Re: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()
- From
Junio C Hamano <junkio@cox.net>
- Date
- Mar 6, 2007, 11:05 UTC
- Message-ID
- <7vlkiapr70.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070306110156.GA13380@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> On Tue, Mar 06, 2007 at 02:58:37AM -0800, Junio C Hamano wrote: > >> Sorry, what I meant to say was on top of Li's patch. > > Ah, I understand your point now. Yes, if other mod_perl CGIs can impact > the value, then we should definitely set it explicitly, as per your > patch (and we should use Li's patch for safety, then, not mine).
Reading "sub autoEscape", "sub escapeHTML" and "sub self_or_default" again, I think other people cannot affect the value of our $cgi->{'escape'} by calling autoEscape, so what I said is probably bogus. Let's use Li's original patch.