Re: [PATCH] gitweb: Change to use explicitly function call cgi->escapHTML()

From: Jeff King <peff@peff.net>
Date: Mar 6, 2007, 10:41 UTC
Message-ID: <20070306104127.GA13096@coredump.intra.peff.net>
In-Reply-To: <989B956029373F45A0B8AF02970818902DAA12@zch01exm26.fsl.freescale.net>

On Tue, Mar 06, 2007 at 06:31:23PM +0800, Li Yang-r58472 wrote:

> Yes, it also fixed the problem.  I'm not very familiar with perl.  Will
> CGI::autoEscape(1) change CGI action for other users of CGI module on
> the system?  If so, maybe it will break other CGIs.

I don't know enough about mod_perl to say, but if all scripts share the package globals from CGI, then yes, you're affecting all other scripts. Without mod_perl, obviously you have no impact.

If it is the case, then your original fix is probably better.

-Peff