Re: First cut at git port to Cygwin

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 6, 2005, 09:05 UTC
Message-ID: <81b0412b0510060205v4cd510c9wb4b06a3ed9242c8@mail.gmail.com>
In-Reply-To: <20051005202947.GA6184@trixie.casa.cgf.cx>

On 10/5/05, Christopher Faylor <me@cgf.cx> wrote:

Show 5 quoted lines

> >Don't think so, but will check in about 10 hrs. The code in question
> >is in index.c, commit_index_file.
>
> Ok.  Looks pretty simple.  FWIW, I've just built git on windows and I
> don't see this behavior.  For the most part, it "just works".

Thanks for the hint. There are open files involved (both index.lock and index). I attach the patch which closes index.lock (this is not really needed, btw: rename works even without closing index.lock) and unmaps the index (a bit too intrusive). The patch fixes only update-index.c (the one I had problems with), there probably are other places were the situation is alike.

I don't like the patch (and win32 at all; hence the offending comment), so use it only unless there is no other possibility to workaround. I specifically do not request its inclusion into official branch (even though Junio is cc'ed).