Re: [PATCH] Fix symbolic ref validation

From: Junio C Hamano <junkio@cox.net>
Date: Oct 5, 2005, 16:54 UTC
Message-ID: <7vk6grykdo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051005155212.GA16391@diku.dk>

Jonas Fonseca <fonseca@diku.dk> writes:

Show 15 quoted lines

> Yes, used rsync when I cloned. Seems validate_symref() was buggy. 
>
>> The other errors could also stem from the fact that quite a few places 
>> expect HEAD to be a symlink.
>
> git-reset still error out ...
>
> ---
>
> Use the correct buffer when validating 'ref: refs/...'
>
> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
>
> ---
> diff --git a/refs.c b/refs.c

Thanks.

One request, not just to Jonas. Please do not use '^---$' to separate the introductory discussion and the real commit log message.

Linus style (recently the kernel list had a thread on this as well) is to have the commit log upfront with signoff, three-dash line, optional discussion and diffstat, and then diff.

I do not mind seeing discussion upfront personally [*1*], but the thing is the tool treats everything after the first '^---$' something to be fed to patch, and does not treat it as the commit log message.

[Footnote]

*1* ...but remember, Linus does.