Re: First cut at git port to Cygwin
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Oct 8, 2005, 18:49 UTC
- Message-ID
- <20051008184925.GA6347@steel.home>
- In-Reply-To
- <Pine.LNX.4.63.0510082023130.25971@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin, Sat, Oct 08, 2005 20:27:06 +0200:
Show 11 quoted lines
> > I really think that you should just get rid of the mmap. > > > > As it is, you're just slowing the code down on sane architectures. That's > > not good. > > > > So I'd suggest something like this instead. > > > > Totally untested, of course. > > Am I missing something? I don't see where the changes are written back to > the fd. After all, mmap() is called with PROT_WRITE...
It's just becase the file is open for reading only. Also, it is not an mmap/unmap implementation. Just reading cache in.