git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: First cut at git port to Cygwin

From
Junio C Hamano <junkio@cox.net>
Date
Oct 8, 2005, 18:44 UTC
Message-ID
<7vr7avrgr2.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0510082023130.25971@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Am I missing something? I don't see where the changes are written back to 
> the fd. After all, mmap() is called with PROT_WRITE...

PROT_WRITE is true, but we do MAP_PRIVATE, and if I recall correctly we do not write file via mmap -- at least we do not intend to.

 - index file is mapped for reading, long ago it was mapped
   read-only but these days we do PROT_WRITE, but updates are
   done via opening a new file and writing afresh.
 - objects are mapped for reading, but, never updated once
   created.  Creation side is regular open - write - close.
 - diff reads original by mapping, but obviously has no business
   writing.
 - local-fetch reads original by mapping for copying.
> *shameless plug* Of course, this problem does not come up with
> my NO_MMAP patch.

Yes. It might have been overkill that you supported writing changes back, though. .

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 42 of 62 in “First cut at git port to Cygwin”
  1. H. Peter AnvinSep 29, 2005
  2. Junio C HamanoSep 29, 2005
  3. H. Peter AnvinSep 29, 2005
  4. Martin LanghoffSep 29, 2005
  5. Junio C HamanoSep 29, 2005
  6. H. Peter AnvinSep 29, 2005
  7. Johannes SchindelinSep 29, 2005
  8. H. Peter AnvinSep 29, 2005
  9. H. Peter AnvinSep 29, 2005
  10. Junio C HamanoSep 30, 2005
  11. H. Peter AnvinSep 30, 2005
  12. H. Peter AnvinSep 30, 2005
  13. Alex RiesenOct 4, 2005
  14. Alex RiesenOct 4, 2005
  15. H. Peter AnvinOct 4, 2005
  16. Christopher FaylorOct 5, 2005
  17. H. Peter AnvinOct 4, 2005
  18. Christopher FaylorOct 5, 2005
  19. H. Peter AnvinOct 5, 2005
  20. Alex RiesenOct 5, 2005
  21. Alex RiesenOct 5, 2005
  22. Christopher FaylorOct 5, 2005
  23. Davide LibenziOct 5, 2005
  24. Christopher FaylorOct 5, 2005
  25. H. Peter AnvinOct 5, 2005
  26. Christopher FaylorOct 5, 2005
  27. Davide LibenziOct 5, 2005
  28. Alex RiesenOct 5, 2005
  29. Christopher FaylorOct 5, 2005
  30. Alex RiesenOct 6, 2005
  31. Alex RiesenOct 6, 2005
  32. Alex RiesenOct 7, 2005
  33. Linus TorvaldsOct 7, 2005
  34. Alex RiesenOct 7, 2005
  35. Alex RiesenOct 7, 2005
  36. Chuck LeverOct 7, 2005
  37. Alex RiesenOct 7, 2005
  38. Linus TorvaldsOct 8, 2005
  39. Elfyn McBratneyOct 8, 2005
  40. Elfyn McBratneyOct 8, 2005
  41. Johannes SchindelinOct 8, 2005
  42. Junio C HamanoOct 8, 2005
  43. Johannes SchindelinOct 8, 2005
  44. Junio C HamanoOct 8, 2005
  45. Johannes SchindelinOct 8, 2005
  46. H. Peter AnvinOct 10, 2005
  47. Johannes SchindelinOct 10, 2005
  48. H. Peter AnvinOct 10, 2005
  49. Johannes SchindelinOct 10, 2005
  50. Junio C HamanoOct 10, 2005
  51. Junio C HamanoOct 10, 2005
  52. H. Peter AnvinOct 10, 2005
  53. Daniel BarkalowOct 10, 2005
  54. Alex RiesenOct 8, 2005
  55. Commit text BEFORE the dashes (Re: First cut at git port to Cygwin)Matthias Urlichs, Oct 9, 2005
  56. Jonas FonsecaOct 5, 2005
  57. Johannes SchindelinOct 5, 2005
  58. Fix symbolic ref validationJonas Fonseca, Oct 5, 2005
  59. Junio C HamanoOct 5, 2005
  60. Alex RiesenOct 7, 2005
  61. Elfyn McBratneyOct 8, 2005
  62. H. Peter AnvinOct 10, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.