Re: First cut at git port to Cygwin
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 10, 2005, 20:34 UTC
- Message-ID
- <7vhdbp3yd7.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <434AC058.60803@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
Show 10 quoted lines
>>>Junio C Hamano wrote: >>> >>>>PROT_WRITE is true, but we do MAP_PRIVATE, and if I recall >>>>correctly we do not write file via mmap -- at least we do not >>>>intend to. >>>> > > In the above sentence, emphasis on "at least we do not intend to." If > writes are done legitimately then that's fine, but we shouldn't have > "accidental writes" -- those would be program bugs!
What I meant to say was "we do not intend to write back the changes by expecting the modification on mapped area are written back by mmap() mechanism -- the updates to index file is done by creat - write - close - rename". So your saying "the overkill being actively wrong" was technically correct, but that wrongly written data was renamed out anyway and no real harm was done.