Re: First cut at git port to Cygwin
- From
- H. Peter Anvin <hpa@zytor.com>
- Date
- Oct 10, 2005, 18:43 UTC
- Message-ID
- <434AB663.8050205@zytor.com>
- In-Reply-To
- <7vr7avrgr2.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 5 quoted lines
> > PROT_WRITE is true, but we do MAP_PRIVATE, and if I recall > correctly we do not write file via mmap -- at least we do not > intend to. >
Then PROT_READ probably makes more sense?
> > Yes. It might have been overkill that you supported writing > changes back, though.
Not just overkill; if we do MAP_PRIVATE it's actively WRONG.
-hpa