Re: Unapplied patches reminder

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2009, 23:31 UTC
Message-ID: <7vzl7ogtxs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091019052030.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 22 quoted lines

> Junio, I saw these patches and thought what they try to do were 
> sensible, but I don't them in your tree. I didn't see much discussion 
> on most of them, either.
>
> Because I don't read C very well, I may have listed some patches 
> here that you may have discarded because the code was no good, and 
> if so I apologize for wasting your time, but I thought at least 
> some of them should be salvaged.
> ...
> From: "Rolf Bjarne Kvinge" <RKvinge@novell.com>
> Subject: git rev-list --pretty=raw strips empty lines
> Date: Tue, 06 Oct 2009 14:33:37 +0200
> Message-ID: <op.u1do6bq5k71drc@linux.lacasa>
>
>     It seems like the --pretty=raw format strips off empty newlines from
>     the beginning of log messages, while I'd expect the raw format to
>     not do any transformations (just as the documentation says: "The
>     'raw' format shows the entire commit exactly as stored in the commit
>     object").
>
>     The below changes works for me, not sure if I'm right about this
>     though (my first time here ;-)

I do not recall seeing this one; most likely it was lost in the noise, especially because it did not look like a patch submission, without having anything resembling a commit log message.

I think the change itself is an uncontroversial one, even though this really changes the behaviour.

Show 7 quoted lines

> From: Per Strandh <Per.Strandh@q-matic.se>
> Subject: [PATCH] git-p4: Fixed bug that didn't allow spaces in the depot
> Date: Tue, 13 Oct 2009 22:09:12 +0200
> Message-ID: <65D9329CA2AF94438F542D48F2A42E830F95F51514@GOT-SRV-005.QMATIC.local>
>
>     git-p4 clone (and sync) did not work if the specified depot path contained spaces.
>     Fixed by quoting the argument to the "p4 changes" and "p4 files" commands.

I do recall ignoring this one because (1) I never use git-p4 myself and always rely on Acks from people who have been involved in it, and (2) the message was mangled (perhaps it had two or three copies of patches as attachments).