Re: Unapplied patches reminder

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2009, 23:32 UTC
Message-ID: <7voco4gtxd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091019052030.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 18 quoted lines

> Junio, I saw these patches and thought what they try to do were 
> sensible, but I don't them in your tree. I didn't see much discussion 
> on most of them, either.
>
> Because I don't read C very well, I may have listed some patches 
> here that you may have discarded because the code was no good, and 
> if so I apologize for wasting your time, but I thought at least 
> some of them should be salvaged.
> ...
> From: Geoffrey Thomas <geofft@mit.edu>
> Subject: [PATCH] diffcore-order: Default the order file to .git/info/order.
> Date: Sat, 12 Sep 2009 19:49:48 -0400
> Message-ID: <1252799388-16295-1-git-send-email-geofft@mit.edu>
>
>     Since order files tend to be useful for all operations in the
>     project/repository, add a default location for the order file, so that
>     you don't have to specify -O<orderfile> on every diff or similar
>     operation.

Except that "$GIT_DIR/info/order" is a bit too generic a name ("eh, 'order'? Order of what?"), I do not think this will hurt, as no existing repositories would have such a file that would cause any behaviour change to existing users. The reason I did not queue it was because there wasn't any discussion on it (not even the filename being too generic) which was an indication that not many people are interested in such a feature.

That of course can be remedied by interested people speaking out.