Re: Unapplied patches reminder

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2009, 23:31 UTC
Message-ID: <7vbpk4i8ii.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091019052030.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

Show 16 quoted lines

> Junio, I saw these patches and thought what they try to do were 
> sensible, but I don't them in your tree. I didn't see much discussion 
> on most of them, either.
>
> Because I don't read C very well, I may have listed some patches 
> here that you may have discarded because the code was no good, and 
> if so I apologize for wasting your time, but I thought at least 
> some of them should be salvaged.
> ...
> From:	Heiko Voigt <hvoigt@hvoigt.net>
> Subject: [PATCH] fix testsuite to not use any hooks possibly provided by source
> Date:	Wed, 23 Sep 2009 20:30:28 +0200
> Message-ID: <20090923183023.GA85456@book.hvoigt.net>
>
>     This is useful if you are using the testsuite with local changes that
>     include activated default hooks suitable for your teams installation.

This may be useful when Heiko or somebody actually has changes that needs this fix, but otherwise was an unnecessary code churn during pre-release code freeze. I am reasonably sure that Heiko will include it in a series that requires this one.

In other words, I am not against it per-se, but I would prefer to see patches that actually depends on this change at the same time. Otherwise this "is supposed to be no-op, and promises it will help in the future", and needs extra mental effort to validate the latter claim.