Re: Re: Unapplied patches reminder

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Oct 19, 2009, 08:10 UTC
Message-ID: <20091019081050.GB44290@book.hvoigt.net>
In-Reply-To: <7vbpk4i8ii.fsf@alter.siamese.dyndns.org>

On Sun, Oct 18, 2009 at 04:31:49PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> Nanako Shiraishi <nanako3@lavabit.com> writes:
> > ...
> > From:	Heiko Voigt <hvoigt@hvoigt.net>
> > Subject: [PATCH] fix testsuite to not use any hooks possibly provided by source
> > Date:	Wed, 23 Sep 2009 20:30:28 +0200
> > Message-ID: <20090923183023.GA85456@book.hvoigt.net>
> >
> >     This is useful if you are using the testsuite with local changes that
> >     include activated default hooks suitable for your teams installation.
> 
> This may be useful when Heiko or somebody actually has changes that needs
> this fix, but otherwise was an unnecessary code churn during pre-release 
> code freeze.  I am reasonably sure that Heiko will include it in a series
> that requires this one.
> 
> In other words, I am not against it per-se, but I would prefer to see
> patches that actually depends on this change at the same time.  Otherwise
> this "is supposed to be no-op, and promises it will help in the future",
> and needs extra mental effort to validate the latter claim.

Well, currently we do not have any activated hooks. They are all sample. And because the use scenarios for git are so diverse we will probably never have any default hook activated. But I imagine that if you are creating a default installation for any team you will activate some. For an example take this patch:

http://thread.gmane.org/gmane.comp.version-control.git/110874

it is not in master because it was to specific but I have such a hook activated. It does not allow you to commit on master which breaks the testsuite.

So in my opinion we should not run the testsuite with hooks even though the current defaults are all deactivated.

I am afraid that I will never be able to persuade everyone on the list to not commit on master... ;)

cheers Heiko

P.S.: Just thinking of previous hooks, I might make it an option like
      hooks.doNotCommitOnMaster. But still the hooks would be
      deactivated.