git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[LHF] making t5000 "tar xf" tests more lenient

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 24, 2012, 20:49 UTC
Message-ID
<7vwqw7mb09.fsf@alter.siamese.dyndns.org>

I've been running testsuite on a few platforms that are unfamiliar to me, and was bitten by BSD implementation of tar that do not grok the extended pax headers. I've already fixed one in t9502 [*1*] where we produce a tarball with "git archive" and then try to validate it with the platform implementation of "tar" so that the test won't barf when it sees the extended pax header.

t5000 is littered with similar tests that break unnecessarily with BSD implementations. I think what it wants to test are:

 - "archive" produces tarball, and "tar" can extract from it.  If
   your "tar" does not understand pax header, you may get it as an
   extra file that shouldn't be there, but that should not cause the
   test to fail---in real life, people without a pax-aware "tar"
   will just ignore and remove the header and can go on.
 - "get-tar-commmit-id" can inspect a tarball produced by "archive"
   to recover the object name of the commit even on a platform
   without a pax-aware "tar".
Perhaps t5000 can be restructured like so:
 - create a tarball with the commit-id and test with
   "get-tar-commit-id" to validate it; also create a tarball out of
   a tree to make sure it does not have commit-id and check with
   "get-tar-commit-id".  Do this on any and all platform, even on
   the ones without a pax-aware "tar".
 - check platform implementation of "tar" early to see if extracting
   a simple output from "git archive" results in an extra pax header
   file.  If so, remember this fact and produce any and all tarballs
   used in the remainder of the test by forcing ^{tree}.

so that people on platforms without pax-aware "tar" do not have to install GNU tar only to pass this test.

It would be a good exercise during the holiday week for somebody on BSD (it seems NetBSD is more troublesome than OpenBSD) to come up with a patch to help users on these platforms.

Thanks.
[Footnote]
*1* http://thread.gmane.org/gmane.comp.version-control.git/211803
Next: René Scharfe
Message 1 of 23 in “[LHF] making t5000 "tar xf" tests more lenient”
  1. Junio C HamanoDec 24, 2012
  2. René ScharfeJan 5, 2013
  3. Junio C HamanoJan 5, 2013
  4. Junio C HamanoJan 5, 2013
  5. René ScharfeJan 5, 2013
  6. archive-tar: split long paths more carefullyRené Scharfe, Jan 5, 2013
  7. Jonathan NiederJan 5, 2013
  8. Junio C HamanoJan 6, 2013
  9. archive-zip: write uncompressed size into header even with streamingRené Scharfe, Jan 6, 2013
  10. 0/4 ZIP test fixesRené Scharfe, Jan 6, 2013
  11. 1/4 t0024, t5000: clear variable UNZIP, use GIT_UNZIP insteadRené Scharfe, Jan 6, 2013
  12. Jonathan NiederJan 7, 2013
  13. René ScharfeJan 7, 2013
  14. 2/4 t0024, t5000: use test_lazy_prereq for UNZIPRené Scharfe, Jan 6, 2013
  15. Matt KraaiJan 6, 2013
  16. René ScharfeJan 6, 2013
  17. Jonathan NiederJan 7, 2013
  18. René ScharfeJan 7, 2013
  19. 3/4 t5000, t5002: move ZIP tests into their own scriptRené Scharfe, Jan 6, 2013
  20. 4/4 t5002: check if unzip supports symlinksRené Scharfe, Jan 6, 2013
  21. Jonathan NiederJan 7, 2013
  22. René ScharfeJan 7, 2013
  23. Jonathan NiederJan 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.