Re: [PATCH 1/4] t0024, t5000: clear variable UNZIP, use GIT_UNZIP instead

From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Jan 7, 2013, 16:25 UTC
Message-ID: <50EAF703.7070806@lsrfire.ath.cx>
In-Reply-To: <20130107051609.GB27909@elie.Belkin>

Am 07.01.2013 06:16, schrieb Jonathan Nieder:

Show 13 quoted lines

> René Scharfe wrote:
>
>> InfoZIP's unzip takes default parameters from the environment variable
>> UNZIP.  Unset it in the test library and use GIT_UNZIP for specifying
>> alternate versions of the unzip command instead.
>>
>> t0024 wasn't even using variable for the actual extraction.  t5000
>> was, but when setting it to InfoZIP's unzip it would try to extract
>> from itself (because it treats the contents of $UNZIP as parameters),
>> which failed of course.
>
> That would only happen if the UNZIP variable was already exported,
> right?

We don't want any parameters a user may have been specified influence the test. I'm not sure if someone actually sets that variable for that purpose, though.

My main use case is running individual test scripts with an alternative unzip binary, and with the patch this works as expected:

	$ cd t
	$ GIT_UNZIP=/usr/pkg/bin/unzip ./t5000-tar-tree.sh

Show 5 quoted lines

> The patch makes sense and takes care of all uses of ${UNZIP} I can
> find, and it even makes the quoting consistent so a person can put
> their copy of unzip under "/Program Files".  For what it's worth,
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks!

René