git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] t0024, t5000: clear variable UNZIP, use GIT_UNZIP instead

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 7, 2013, 05:16 UTC
Message-ID
<20130107051609.GB27909@elie.Belkin>
In-Reply-To
<50E9B8CD.2010209@lsrfire.ath.cx>
René Scharfe wrote:
Show 8 quoted lines
> InfoZIP's unzip takes default parameters from the environment variable
> UNZIP.  Unset it in the test library and use GIT_UNZIP for specifying
> alternate versions of the unzip command instead.
>
> t0024 wasn't even using variable for the actual extraction.  t5000
> was, but when setting it to InfoZIP's unzip it would try to extract
> from itself (because it treats the contents of $UNZIP as parameters),
> which failed of course.

That would only happen if the UNZIP variable was already exported, right?

The patch makes sense and takes care of all uses of ${UNZIP} I can find, and it even makes the quoting consistent so a person can put their copy of unzip under "/Program Files". For what it's worth,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: René ScharfeNext: René Scharfe
Message 12 of 23 in “[LHF] making t5000 "tar xf" tests more lenient”
  1. Junio C HamanoDec 24, 2012
  2. René ScharfeJan 5, 2013
  3. Junio C HamanoJan 5, 2013
  4. Junio C HamanoJan 5, 2013
  5. René ScharfeJan 5, 2013
  6. archive-tar: split long paths more carefullyRené Scharfe, Jan 5, 2013
  7. Jonathan NiederJan 5, 2013
  8. Junio C HamanoJan 6, 2013
  9. archive-zip: write uncompressed size into header even with streamingRené Scharfe, Jan 6, 2013
  10. 0/4 ZIP test fixesRené Scharfe, Jan 6, 2013
  11. 1/4 t0024, t5000: clear variable UNZIP, use GIT_UNZIP insteadRené Scharfe, Jan 6, 2013
  12. Jonathan NiederJan 7, 2013
  13. René ScharfeJan 7, 2013
  14. 2/4 t0024, t5000: use test_lazy_prereq for UNZIPRené Scharfe, Jan 6, 2013
  15. Matt KraaiJan 6, 2013
  16. René ScharfeJan 6, 2013
  17. Jonathan NiederJan 7, 2013
  18. René ScharfeJan 7, 2013
  19. 3/4 t5000, t5002: move ZIP tests into their own scriptRené Scharfe, Jan 6, 2013
  20. 4/4 t5002: check if unzip supports symlinksRené Scharfe, Jan 6, 2013
  21. Jonathan NiederJan 7, 2013
  22. René ScharfeJan 7, 2013
  23. Jonathan NiederJan 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.