git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
Jan 7, 2013, 16:28 UTC
Message-ID
<50EAF7A1.3090602@lsrfire.ath.cx>
In-Reply-To
<20130107084509.GH27909@elie.Belkin>
Am 07.01.2013 09:45, schrieb Jonathan Nieder:
Show 15 quoted lines
> René Scharfe wrote:
>
>> --- a/t/t0024-crlf-archive.sh
>> +++ b/t/t0024-crlf-archive.sh
>> @@ -5,6 +5,11 @@ test_description='respect crlf in git archive'
>>   . ./test-lib.sh
>>   GIT_UNZIP=${GIT_UNZIP:-unzip}
>>
>> +test_lazy_prereq UNZIP '
>> +	"$GIT_UNZIP" -v >/dev/null 2>&1
>> +	test $? -ne 127
>
> Micronit: now that this is part of a test, there is no more need to
> silence its output.  The "unzip -v" output could be useful to people
> debugging with "t0024-crlf-archive.sh -v -i".
Oh, yes, good point.
> With or without that change, this is a nice cleanup and obviously
> correct, so
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks, René

Previous: Jonathan NiederNext: René Scharfe
Message 18 of 23 in “[LHF] making t5000 "tar xf" tests more lenient”
  1. Junio C HamanoDec 24, 2012
  2. René ScharfeJan 5, 2013
  3. Junio C HamanoJan 5, 2013
  4. Junio C HamanoJan 5, 2013
  5. René ScharfeJan 5, 2013
  6. archive-tar: split long paths more carefullyRené Scharfe, Jan 5, 2013
  7. Jonathan NiederJan 5, 2013
  8. Junio C HamanoJan 6, 2013
  9. archive-zip: write uncompressed size into header even with streamingRené Scharfe, Jan 6, 2013
  10. 0/4 ZIP test fixesRené Scharfe, Jan 6, 2013
  11. 1/4 t0024, t5000: clear variable UNZIP, use GIT_UNZIP insteadRené Scharfe, Jan 6, 2013
  12. Jonathan NiederJan 7, 2013
  13. René ScharfeJan 7, 2013
  14. 2/4 t0024, t5000: use test_lazy_prereq for UNZIPRené Scharfe, Jan 6, 2013
  15. Matt KraaiJan 6, 2013
  16. René ScharfeJan 6, 2013
  17. Jonathan NiederJan 7, 2013
  18. René ScharfeJan 7, 2013
  19. 3/4 t5000, t5002: move ZIP tests into their own scriptRené Scharfe, Jan 6, 2013
  20. 4/4 t5002: check if unzip supports symlinksRené Scharfe, Jan 6, 2013
  21. Jonathan NiederJan 7, 2013
  22. René ScharfeJan 7, 2013
  23. Jonathan NiederJan 10, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.