Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 7, 2013, 08:45 UTC
Message-ID: <20130107084509.GH27909@elie.Belkin>
In-Reply-To: <50E9B90C.2060200@lsrfire.ath.cx>

René Scharfe wrote:

Show 9 quoted lines

> --- a/t/t0024-crlf-archive.sh
> +++ b/t/t0024-crlf-archive.sh
> @@ -5,6 +5,11 @@ test_description='respect crlf in git archive'
>  . ./test-lib.sh
>  GIT_UNZIP=${GIT_UNZIP:-unzip}
>  
> +test_lazy_prereq UNZIP '
> +	"$GIT_UNZIP" -v >/dev/null 2>&1
> +	test $? -ne 127

Micronit: now that this is part of a test, there is no more need to
silence its output.  The "unzip -v" output could be useful to people
debugging with "t0024-crlf-archive.sh -v -i".

With or without that change, this is a nice cleanup and obviously
correct, so
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>