git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] progress.c: avoid use of dynamic-sized array

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2008, 22:02 UTC
Message-ID
<7vve0jh9g7.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200806082151.m58Lp6sG014324@mi0.bluebottle.com>
しらいしななこ  <nanako3@bluebottle.com> writes:
Show 17 quoted lines
> Quoting Boyd Lynn Gerber <gerberb@zenez.com>:
>
>> Dynamically sized arrays are gcc and C99 construct.  Using them hurts
>> portability to older compilers, although using them is nice in this case
>> it is not desirable.  This patch removes the only use of the construct
>> in stop_progress_msg(); the function is about writing out a single line
>> of a message, and the existing callers of this function feed messages
>> of only bounded size anyway, so use of dynamic array is simply overkill.
>>
>> Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
>
> I may be mistaken but isn't this Junio's patch?  If so (quoting
> from SubmittingPatches document):
>
>   If you are forwarding a patch from somebody else, optionally, at
>   the beginning of the e-mail message just before the commit
>   message starts, you can put a "From: " line to name that person.
Heh, thanks for being picky ;-)

Something this small, either way is fine by me. Besides, I've applied the patch (and the other one) from Boyd already.

Previous: しらいしななこNext: Boyd Lynn Gerber
Message 6 of 7 in “progress.c: avoid use of dynamic-sized array”
  1. progress.c: avoid use of dynamic-sized arrayBoyd Lynn Gerber, Jun 8, 2008
  2. Johannes SchindelinJun 8, 2008
  3. Boyd Lynn GerberJun 8, 2008
  4. Alex RiesenJun 8, 2008
  5. しらいしななこJun 8, 2008
  6. Junio C HamanoJun 8, 2008
  7. Boyd Lynn GerberJun 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.