Re: [PATCH] progress.c: avoid use of dynamic-sized array

From: しらいしななこ <nanako3@bluebottle.com>
Date: Jun 8, 2008, 21:50 UTC
Message-ID: <200806082151.m58Lp6sG014324@mi0.bluebottle.com>
In-Reply-To: <Pine.LNX.4.64.0806080924330.18454@xenau.zenez.com>

Quoting Boyd Lynn Gerber <gerberb@zenez.com>:

Show 8 quoted lines

> Dynamically sized arrays are gcc and C99 construct.  Using them hurts
> portability to older compilers, although using them is nice in this case
> it is not desirable.  This patch removes the only use of the construct
> in stop_progress_msg(); the function is about writing out a single line
> of a message, and the existing callers of this function feed messages
> of only bounded size anyway, so use of dynamic array is simply overkill.
>
> Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>

I may be mistaken but isn't this Junio's patch? If so (quoting from SubmittingPatches document):

  If you are forwarding a patch from somebody else, optionally, at
  the beginning of the e-mail message just before the commit
  message starts, you can put a "From: " line to name that person.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

----------------------------------------------------------------------
Find out how you can get spam free email.
http://www.bluebottle.com/tag/3