Re: [PATCH] progress.c: avoid use of dynamic-sized array

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 8, 2008, 19:30 UTC
Message-ID: <alpine.DEB.1.00.0806082029170.1783@racer>
In-Reply-To: <Pine.LNX.4.64.0806080924330.18454@xenau.zenez.com>

Hi,

On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:

Show 15 quoted lines

> 
> Dynamically sized arrays are gcc and C99 construct.  Using them hurts
> portability to older compilers, although using them is nice in this case
> it is not desirable.  This patch removes the only use of the construct
> in stop_progress_msg(); the function is about writing out a single line
> of a message, and the existing callers of this function feed messages
> of only bounded size anyway, so use of dynamic array is simply overkill.
> 
> Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
> 
> --
> Boyd Gerber <gerberb@zenez.com>
> ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
> 
> ---

Do you really want to have your mail signature in the commit message, particularly because...

Show 15 quoted lines

> [...]
>
>  	clear_progress_signal();
>  	free(progress->throughput);
> -- 
> 1.5.2.4
> 
> 
> --
> Boyd Gerber <gerberb@zenez.com>
> ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

You repeat it at the end of the mail anyway?

The patch looks fine to me, though.

Ciao, Dscho