Re: [PATCH] progress.c: avoid use of dynamic-sized array
- From
- Boyd Lynn Gerber <gerberb@zenez.com>
- Date
- Jun 8, 2008, 21:53 UTC
- Message-ID
- <Pine.LNX.4.64.0806081551440.18454@xenau.zenez.com>
- In-Reply-To
- <200806082151.m58Lp6sH014324@mi0.bluebottle.com>
On Mon, 9 Jun 2008, しらいしななこ wrote:
Show 16 quoted lines
> Quoting Boyd Lynn Gerber <gerberb@zenez.com>: > > Dynamically sized arrays are gcc and C99 construct. Using them hurts > > portability to older compilers, although using them is nice in this case > > it is not desirable. This patch removes the only use of the construct > > in stop_progress_msg(); the function is about writing out a single line > > of a message, and the existing callers of this function feed messages > > of only bounded size anyway, so use of dynamic array is simply overkill. > > > > Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com> > > I may be mistaken but isn't this Junio's patch? If so (quoting > from SubmittingPatches document): > > If you are forwarding a patch from somebody else, optionally, at > the beginning of the e-mail message just before the commit > message starts, you can put a "From: " line to name that person.
It is his from my orignal modifications. I thought he suggested I make the changes and resubmit it as a seperate patch. Thanks for the clarifications.
-- Boyd Gerber <gerberb@zenez.com> ZENEZ 1042 East Fort Union #135, Midvale Utah 84047