Re: [PATCH] progress.c: avoid use of dynamic-sized array

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jun 8, 2008, 21:34 UTC
Message-ID: <20080608213438.GA3073@steel.home>
In-Reply-To: <Pine.LNX.4.64.0806080924330.18454@xenau.zenez.com>

Boyd Lynn Gerber, Sun, Jun 08, 2008 17:26:15 +0200:

Show 7 quoted lines

>  		/* Force the last update */
> -		char buf[strlen(msg) + 5];
> +		char buf[128], *bufp;
> +		size_t len = strlen(msg) + 5;
>  		struct throughput *tp = progress->throughput;
> +
> +		bufp = (len < sizeof(buf)) ? buf : xmalloc(len + 1);

It is just a temporary buffer, there is no urgent need to micro-optimize the allocation like that. Maybe just leave one of the buffers, the one on stack? It is just a progress message, snprintf will cut it, yes, but it is unlikely to cause any harm (unless you forget to \n-terminate it).