From: Junio C Hamano Date: Sun, 08 Jun 2008 22:02:16 GMT Subject: Re: [PATCH] progress.c: avoid use of dynamic-sized array Message-ID: <7vve0jh9g7.fsf@gitster.siamese.dyndns.org> In-Reply-To: <200806082151.m58Lp6sG014324@mi0.bluebottle.com> しらいしななこ writes: > Quoting Boyd Lynn Gerber : > >> Dynamically sized arrays are gcc and C99 construct. Using them hurts >> portability to older compilers, although using them is nice in this case >> it is not desirable. This patch removes the only use of the construct >> in stop_progress_msg(); the function is about writing out a single line >> of a message, and the existing callers of this function feed messages >> of only bounded size anyway, so use of dynamic array is simply overkill. >> >> Signed-off-by: Boyd Lynn Gerber > > I may be mistaken but isn't this Junio's patch? If so (quoting > from SubmittingPatches document): > > If you are forwarding a patch from somebody else, optionally, at > the beginning of the e-mail message just before the commit > message starts, you can put a "From: " line to name that person. Heh, thanks for being picky ;-) Something this small, either way is fine by me. Besides, I've applied the patch (and the other one) from Boyd already.