Re: v1.5.4 plans

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2007, 01:27 UTC
Message-ID: <7vtzmqhvgq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071210234941.GE22254@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> A few regressions that you did not mention, but I think should be
> addressed before 1.5.4:
>
>  - extra newline in builtin-commit output. You found a case that
>    needs it, but fixing it is non-trivial, and I wanted to get your
>    input before preparing a patch. See
>
>      http://mid.gmane.org/20071203075357.GB3614@sigill.intra.peff.net

I am actually becoming somewhat fond of the newline that makes the end of a session that led to a commit stand out ;-). IOW, I was wondering if we can have another for a merge commit case.

But I suspect that it amounts to the change in the same area and of similar complexity.

Show 8 quoted lines

>  - git-clean's handling of directory wildcards. I didn't get a response
>    to
>
>      http://mid.gmane.org/20071206043247.GC5499@coredump.intra.peff.net
>
>    I suspect there are still some bugs lurking in there, but it's hard
>    to say because I don't know what the behavior _should_ be (there are
>    some test cases in that email).

The last time I looked at the "directory" side of builtin-clean.c, I had to quickly reach for my barf bag. I never use "git clean" without "-n" and I never ever use "git clean" with "-d"; I do not have any idea what behaviour when given "-d" would be useful. AFAIU, the scripted version did not have clear semantics either.

Another thing that irritates me is it talks about not removing a directory when run "git clean -n" (without -d). I did not ask it to remove directories, so I did not expect it to talk about it not doing what I did not ask it to.

Show 5 quoted lines

> And perhaps not a regression, but I think we should bring git-svn's
> handling of color.* in line with the changes to the rest of the code
> before 1.5.4. I posted a "last resort" patch, but I think with your
> changes to "git config --colorbool" it might be possible to use that.
> I'll try to work up a new patch.

Thanks for a reminder.  Anything else?