Re: v1.5.4 plans
- From
Jeff King <peff@peff.net>
- Date
- Dec 11, 2007, 12:53 UTC
- Message-ID
- <20071211125347.GA18140@sigill.intra.peff.net>
- In-Reply-To
- <7vtzmqhvgq.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 10, 2007 at 05:27:17PM -0800, Junio C Hamano wrote:
> Thanks for a reminder. Anything else?
This bugfix has been sitting in my repo for a few weeks. When it last appeared, you asked if the other code paths needed a similar fix, and I verified that they did not, so I think it is complete as-is.
-- >8 -- git-clone: print an error message when trying to clone empty repo
Previously, cloning an empty repository looked like this:
$ (mkdir parent && cd parent && git --bare init) $ git-clone parent child Initialized empty Git repository in /home/peff/clone/child/.git/ $ cd child -bash: cd: child: No such file or directory $ echo 'wtf?' | mail git@vger.kernel.org
Now we at least report that the clone was not successful.
Signed-off-by: Jeff King <peff@peff.net> --- git-clone.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-clone.sh b/git-clone.sh index ecf9d89..96a356d 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -297,7 +297,8 @@ yes) find objects -type f -print | sed -e 1q) # objects directory should not be empty because # we are cloning! - test -f "$repo/$sample_file" || exit + test -f "$repo/$sample_file" || + die "fatal: cannot clone empty repository" if ln "$repo/$sample_file" "$GIT_DIR/objects/sample" 2>/dev/null then rm -f "$GIT_DIR/objects/sample"
-- 1.5.3.7.2224.ge4a5