Re: [PATCH] Remove duplication in t9119-git-svn-info.sh
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 2, 2008, 05:57 UTC
- Message-ID
- <7vabno3h3e.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080102034317.GB11711@untitled>
Eric Wong <normalperson@yhbt.net> writes:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote: >> "David D. Kilzer" <ddkilzer@kilzer.net> writes: >> >> > @@ -350,8 +355,8 @@ test_expect_success 'info unknown-symlink-directory' " >> > cd svnwc && >> > ln -s unknown-directory unknown-symlink-directory && >> > cd .. && >> > - ptouch gitwc/unknown-symlink-directory \ >> > - svnwc/unknown-symlink-directory && >> > + ptouch svnwc/unknown-symlink-directory \ >> > + gitwc/unknown-symlink-directory && >> >> Hmph. Am I the only one who finds this repetition somewhat >> disturbing? > > "David D. Kilzer" <ddkilzer@kilzer.net> wrote: >> Simplify arguments to ptouch bash function. > > Not reading Junio's mind, I think he meant that you were swapping the > "gitwc/" and "svnwc/" args everywhere in your changeset.
Yeah, that was what I meant. ptouch routine's implementation could have swapped the order of arguments internally.
The follow-up patch by David makes ptouch routine unusable if the test suite becomes more elaborate and starts using more than one git and svn work trees, but I do not think that is something we have to worry about too much.