Re: v1.5.4 plans

From: Eric Wong <normalperson@yhbt.net>
Date: Dec 12, 2007, 18:40 UTC
Message-ID: <20071212184022.GB28377@untitled>
In-Reply-To: <7vmysijhwq.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> People might have noticed that I've been ignoring most of the new
> topics/enhancements for the past few days.  Here is what I want to see
> happen until we declare v1.5.4.
> 
> First, stabilize 'master' enough and tag v1.5.4-rc0 soon.

>  * Eric's sanely-compact mapping from SVN rev-ids to git commits saw a
>    positive feedback.  I haven't carefully read that patch but it seemed
>    sane and I'd like to have it in v1.5.4.

It's looking good for most users, I think it's safe enough for 1.5.4

>  * I've seen t9119-git-svn-info.sh fail in my k.org private repository
>    and have been skipping the test, but this needs to be diagnosed and
>    fixed [*1*].  It could be just that the code is fine and the test is
>    not rejecting SVN that is too-old. I dunno.

I wouldn't mind dropping this test for now.

100% output compatibility with SVN is too difficult to achieve and IMHO not worth it for commands like `info' and `log'.

David:

I also noticed some race-conditions on this test when running this on my Centrino laptop (my fastest box, but I rarely use it for git development) and having git on my USB thumb drive. I'm pretty sure these were caused by inconsistencies in handling timestamps on symlinks vs timestamps on the files they link to.

Show 28 quoted lines

> *1* t9119 first fails at the 6th test.  Perhaps the test needs to check
> svn version first and stop testing this feature.  This test does not
> fail on my personal box that has svn 1.4.2.
> 
> * expecting success:
>         (cd svnwc; svn info file) > expected.info-file &&
>         (cd gitwc; git-svn info file) > actual.info-file &&
>         git-diff expected.info-file actual.info-file
> 
> diff --git a/expected.info-file b/actual.info-file
> index b1d57f4..997c927 100644
> --- a/expected.info-file
> +++ b/actual.info-file
> @@ -10,6 +10,5 @@ Last Changed Author: junio
>  Last Changed Rev: 1
>  Last Changed Date: 2007-12-10 22:18:12 +0000 (Mon, 10 Dec 2007)
>  Text Last Updated: 2007-12-10 22:18:13 +0000 (Mon, 10 Dec 2007)
> -Properties Last Updated: 2007-12-10 22:18:13 +0000 (Mon, 10 Dec 2007)
>  Checksum: 5bbf5a52328e7439ae6e719dfe712200
> 
> * FAIL 6: info file
> 
>                 (cd svnwc; svn info file) > expected.info-file &&
>                 (cd gitwc; git-svn info file) > actual.info-file &&
>                 git-diff expected.info-file actual.info-file
> 
> : hera t/master; svn --version
> svn, version 1.3.2 (r19776)

-- 
Eric Wong