Re: [PATCH] Remove duplication in t9119-git-svn-info.sh

From: David D. Kilzer <ddkilzer@kilzer.net>
Date: Jan 2, 2008, 03:54 UTC
Message-ID: <526767.57295.qm@web52401.mail.re2.yahoo.com>
In-Reply-To: <20080102034317.GB11711@untitled>

Eric Wong <normalperson@yhbt.net> wrote:

> Not reading Junio's mind, I think he meant that you were swapping the
> "gitwc/" and "svnwc/" args everywhere in your changeset.

I did not switch them everywhere. The original patch to fix the race condition required switching the arguments because I had to treat the svnwc path differently than the gitwc path.

> Nevertheless, does your change make things work with older
> versions of SVN?  I'm running 1.4.x everywhere these days, but
> I seem to recall the version of SVN on kernel.org was giving
> Junio trouble with the tests.

Was it the "race condition" he was seeing, where the tests were failing because of a difference in one second between the svn output and the git output? If so, that was fixed with the first patch. I was able to reproduce the race condition locally with svn-1.4.5 on my PowerBook G4.

I don't have an easy way to test with svn-1.3.

Dave