From: Junio C Hamano <junkio@cox.net>
Date: Wed, 20 Sep 2006 23:32:42 GMT
Subject: Re: [PATCH] gitweb: Fix showing of path in tree view
Message-ID: <7vpsdqdsh1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060920231224.GN13132@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

> This patch fixes two things - links to all path elements except the last
> one were broken since gitweb does not like the trailing slash in them, and
> the root tree was not reachable from the subdirectory view.
>
> To compensate for the one more slash in the front, the trailing slash is
> not there anymore. ;-) I don't care if it stays there though.

Hmph.  I see the breakage and behaviour-wise your patch is fine.

But I think the older one was visually nicer and more intuitive
in one very small detail that I think matters.  Slashes between
path components were not part of the anchor elements, so it was
clear that there were two links in "gitweb / gitweb.perl" page
title, not just one link.  Now it is not obvious that clicking
different parts of the path string in "/stgit/commands/mail.py"
would lead to different places.  And as you are aware, losing
the leading "/" would be nicer as well ;-).