Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 29, 2012, 18:15 UTC
Message-ID: <7vlinltsja.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F4E003C.1050301@seap.minhap.es>

Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:

Show 9 quoted lines

> On 02/28/2012 08:24 PM, Junio C Hamano wrote:
>
>> I've heard rumors that libcurl on some versions/installations of Mac OS X
>> deliberately ignores the environment. For those who agree with Apple, it
>> would be a regression if we suddenly start the environment ourselves and
>> using it.
>
> Hi Junio, what did you mean by "we start the environment and using it"?
> I didn't understand what you mean there..

The reason you didn't understand is because the statement does not parse X-<. Thanks for pointing it out.

What I meant was that on these platforms, allegedly (note that I do not have a first-hand experience with them), user's http_proxy environment setting did not affect libcurl based applications and that is a deliberate platform decision to give precedence to proxy settings the platform has elsewhere. The users who agree with this platform decision are happily using the proxy settings stored elsewhere in the platform with git, but may have http_proxy environment pointing at a proxy that they do not want to use for git.

If we suddenly start reading from http_proxy environment ourselves and explicitly telling libcurl to use the proxy specified, it will change the behaviour for these users, i.e. a regression.