Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set

From: Jeff King <peff@peff.net>
Date: Feb 28, 2012, 19:34 UTC
Message-ID: <20120228193443.GB11725@sigill.intra.peff.net>
In-Reply-To: <4F4D2AAD.3040107@vilain.net>

On Tue, Feb 28, 2012 at 11:27:41AM -0800, Sam Vilain wrote:

Show 16 quoted lines

> On 2/28/12 11:15 AM, Jeff King wrote:
> >Usually we would prefer environment variables to config. So that:
> >
> >   $ git config http.proxy foo
> >   $ HTTP_PROXY=bar git fetch
> >
> >would use "bar" as the proxy, not "foo". But your code above would
> >prefer "foo", right?
> 
> Apparently I'm the author of the http.proxy feature, though I barely
> remember what problem I was actually solving at the time.  At the
> time I justified it on the grounds that a user might want to use a
> different proxy for git and/or a particular remote.  The "http_proxy"
> environment variable is likely to be a global system default, or
> perhaps a desktop setting, and therefore I'd say probably less and
> not more specific than a git configuration variable.

Good point. We sometimes follow this order:

  1. git-specific environment variables (i.e., $GIT_HTTP_PROXY, if
     it existed)
  2. git config files (i.e., http.proxy)
  3. generic system environment (i.e., $http_proxy).

So thinking about it that way, the original patch makes more sense.

-Peff